Draft
Conversation
Run RBS::InlineParser.parse() once per file during parse_rb and build a lookup table keyed by Prism node object_id. DefNode now resolves inline RBS annotations via this lookup first, falling back to the manual get_rbs_comment_before for top-level methods.
Extend InlineParser lookup to also collect AttrReaderMember, AttrWriterMember, and AttrAccessorMember. When an inline type annotation (e.g. `attr_reader :foo #: Integer`) is present, add a method_decl_box to constrain the inferred type.
Drop the manual RBS comment extraction fallback now that InlineParser handles all in-class method annotations. Update 9 scenario files to wrap previously top-level methods inside classes, and remove the unused comments field from FileContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP